Code review Kata with Gerrit

Manuel Vacelet / @vaceletm

Creative Commons License
This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 Unported License.

Bio / context

Why to review code?

Where it comes from?

  • Well known practice in FLOSS world
  • Various strategy: Linux (LKML), "pull requests"

Gerrit

http://code.google.com/p/gerrit/

  • Comes from Android project
  • Git only
  • users: Eclipse, QT, Mediawiki, Sony, Motorola, Google, SAP, ...

Gerrit workflow

Reviews dashboard

One review

Patch

Diff, comments

Push for review

git push ssh://vaceletm@gerrit.tuleap.net:29418 HEAD:refs/for/master
  • One commit == One review
  • Shape your commits (history rewriting!)

Commits: Size matters

  • Beware The Big One
  • Difficult to grasp it
  • Tiny not better whatsoever

Shape your commits!

Access control

Conclusion

  • Powerful (access, rules)
  • 2.6 + JGit: more efficient than raw access
  • High learning curve

Questions?

Credits